feat/select primitive multiselect #2775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces multiselect functionality to the Select primitive component by creating a custom Radix Select implementation with enhanced multiselection capabilities.
- Extracts and modifies Radix UI Select primitive to support multiselection
- Updates Select component to handle both single and multiple value selection
- Refactors existing component dependencies to use the new custom primitive
Reviewed Changes
Copilot reviewed 20 out of 24 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/react/src/ui/Select/components/radix-ui/select.tsx | Creates custom Select primitive with multiselection support extracted from Radix UI |
| packages/react/src/ui/Select/components/radix-ui/index.ts | Exports all components from custom Select primitive |
| packages/react/src/ui/Select/components/Select.tsx | Updates main Select component to handle multiple values and use custom primitive |
| packages/react/src/ui/Select/components/SelectItem.tsx | Adds checkbox support for multiselect items |
| packages/react/src/ui/Select/components/SelectContent.tsx | Updates to use custom primitive and removes loading indicators |
| packages/react/src/ui/Select/SelectContext.tsx | Enhances context to support multiple values |
| packages/react/src/ui/Select/stories/select.stories.tsx | Adds multiselect story and updates imports |
| packages/react/package.json | Adds new Radix UI dependencies for custom primitive |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
🔍 Visual review for your branch is published 🔍Here are the links to: |
sergiocarracedo
force-pushed
the
feat/select-primitive-multiselect
branch
from
e0034b3 to
a7c6719
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 20 out of 24 changed files in this pull request and generated 6 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
size-limit report 📦
|
sergiocarracedo
force-pushed
the
feat/select-primitive-multiselect
branch
from
a7c6719 to
4fc725c
Compare
sergiocarracedo
force-pushed
the
feat/select-primitive-multiselect
branch
from
4fc725c to
bd2e8f8
Compare
sauldom102
reviewed
Oct 7, 2025
nlopin
reviewed
Oct 7, 2025
nlopin
reviewed
Oct 7, 2025
nlopin
reviewed
Oct 7, 2025
nlopin
reviewed
Oct 7, 2025
nlopin
approved these changes
Oct 9, 2025
sauldom102
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshots (if applicable)
Screen.Recording.2025-10-07.at.14.22.43.mov
[Link to Figma Design](Figma URL here)
Implementation details
We needed to rewrite the SelectPrimitive to allow multiselection: Implmenetation from: https://github.com/radix-ui/primitives/blob/b3ee588dcb339d6c6ce524fcdd968c5eeb4e8458/packages/react/select/src/select.tsx